New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search and filters #46
Comments
This could be done completely client-side, within the DOM, but @valeriangalliat and I wished to have something a little more focused on data rather than presentation. |
I think exposing the whole data to the client side would be great. <script>window.data = {{ data | json }}</script> is easy. |
After trying to injecting the whole data into the page I think that it is to much. Here is an DOM approach using fuse.js and injecting only Development is on branch |
A word regarding inline-search (items get filtered and hidden/displayed as you're typing): On paper, I like that. It does the job well since I automatically get rid of all the items I don't want as I'm typing in the search bar. That's what we have at Browserhacks and it's working pretty well. There are 2 things I don't like with this system though:
I'd rather keep things simple: I type, I get suggestions, I pick one and get redirected to the selected item (anchor in our case). |
Fixed by 06576f5 |
Would be cool to be able to search and filter documented items.
The text was updated successfully, but these errors were encountered: