Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't parse @import #73

Closed
KittyGiraudel opened this issue Jul 8, 2014 · 6 comments
Closed

Shouldn't parse @import #73

KittyGiraudel opened this issue Jul 8, 2014 · 6 comments
Assignees
Labels
Milestone

Comments

@KittyGiraudel
Copy link
Member

I've finally understood the issue we have when running SassDoc on view/scss: because some @import directives directly follow a C-style comment, they get parsed.

/**
 * Partials
 */
@import "partials/header";

This should not happen.

@KittyGiraudel KittyGiraudel added this to the 1.0 milestone Jul 8, 2014
@KittyGiraudel
Copy link
Member Author

Merged in 1.0.0-rc.12.

@KittyGiraudel
Copy link
Member Author

@FWeinb, are you sure you fixed this?

I had to do: https://github.com/HugoGiraudel/SassDoc/blob/master/view/templates/documentation/index.html.swig#L18. Which is a safe measure, but which is not very clean.

Any hint?

@FWeinb
Copy link
Member

FWeinb commented Jul 8, 2014

npm install scsscommentparser@0.0.18

@liaoyongfu
Copy link

Why do I @import "a.scss" in the SCSS file, but "a.scss" will not be documented?

@pascalduez
Copy link
Member

Why do I @import "a.scss" in the SCSS file, but "a.scss" will not be documented?

SassDoc won't resolve and import Sass @import statements, it's not its role.

To document several files use the source argument:

<src> is the path to one or more Sass folders or glob expressions to SCSS/Sass files

@liaoyongfu
Copy link

@pascalduez , Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants