Shouldn't parse @import #73

Closed
HugoGiraudel opened this Issue Jul 8, 2014 · 6 comments

Comments

Projects
None yet
4 participants
@HugoGiraudel
Member

HugoGiraudel commented Jul 8, 2014

I've finally understood the issue we have when running SassDoc on view/scss: because some @import directives directly follow a C-style comment, they get parsed.

/**
 * Partials
 */
@import "partials/header";

This should not happen.

@HugoGiraudel HugoGiraudel added this to the 1.0 milestone Jul 8, 2014

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 8, 2014

Member

Merged in 1.0.0-rc.12.

Member

HugoGiraudel commented Jul 8, 2014

Merged in 1.0.0-rc.12.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 8, 2014

Member

@FWeinb, are you sure you fixed this?

I had to do: https://github.com/HugoGiraudel/SassDoc/blob/master/view/templates/documentation/index.html.swig#L18. Which is a safe measure, but which is not very clean.

Any hint?

Member

HugoGiraudel commented Jul 8, 2014

@FWeinb, are you sure you fixed this?

I had to do: https://github.com/HugoGiraudel/SassDoc/blob/master/view/templates/documentation/index.html.swig#L18. Which is a safe measure, but which is not very clean.

Any hint?

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Jul 8, 2014

Member

npm install scsscommentparser@0.0.18

Member

FWeinb commented Jul 8, 2014

npm install scsscommentparser@0.0.18

@liaoyongfu

This comment has been minimized.

Show comment
Hide comment
@liaoyongfu

liaoyongfu Aug 28, 2015

Why do I @import "a.scss" in the SCSS file, but "a.scss" will not be documented?

Why do I @import "a.scss" in the SCSS file, but "a.scss" will not be documented?

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Aug 28, 2015

Member

Why do I @import "a.scss" in the SCSS file, but "a.scss" will not be documented?

SassDoc won't resolve and import Sass @import statements, it's not its role.

To document several files use the source argument:

<src> is the path to one or more Sass folders or glob expressions to SCSS/Sass files

Member

pascalduez commented Aug 28, 2015

Why do I @import "a.scss" in the SCSS file, but "a.scss" will not be documented?

SassDoc won't resolve and import Sass @import statements, it's not its role.

To document several files use the source argument:

<src> is the path to one or more Sass folders or glob expressions to SCSS/Sass files

@liaoyongfu

This comment has been minimized.

Show comment
Hide comment
@liaoyongfu

liaoyongfu Aug 28, 2015

@pascalduez , Thanks very much!

@pascalduez , Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment