Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pandas not testing for correct column names #1436

Closed
benhammondmusic opened this issue Feb 4, 2022 · 1 comment
Closed

Pandas not testing for correct column names #1436

benhammondmusic opened this issue Feb 4, 2022 · 1 comment
Assignees
@benhammondmusic
Labels
bug Something isn't working cleanup Code health cleanups

Comments

@benhammondmusic
Copy link
Collaborator 

assert_frame_equal(mock_bq.call_args_list[i].args[0], expected_df, check_like=True)

seems to only test for deep equality of matching columns, however the tests pass if the expected df has different column names than the mocked df. This can accidentally allow malformed data to pass the test phase
@benhammondmusic benhammondmusic added bug Something isn't working cleanup Code health cleanups labels Feb 4, 2022
@benhammondmusic benhammondmusic mentioned this issue Feb 8, 2022
Merged
2 tasks
@benhammondmusic benhammondmusic mentioned this issue Mar 14, 2022
Merged
@benhammondmusic
Copy link
Collaborator Author

cant reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benhammondmusic benhammondmusic

Labels
bug Something isn't working cleanup Code health cleanups
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshzarrabi @benhammondmusic