Minitest port API test_contentview

[ldjebran]

Target project : Katello

• test_negative_create_with_invalid_name
• test_positive_clone
• test_positive_create_composite
• test_positive_create_with_description
• test_positive_create_with_name
• test_positive_publish_with_long_name -- do not port
• test_negative_update_label
• test_negative_update_name
• test_positive_update_attributes
• test_positive_update_name
• test_positive_delete

[pondrejk]

Well, if something is tested in Katello, it is CVs, so minimal changes introduced in my PR, majority of listed tests already existed in some form, summary:

test_negative_create_with_invalid_name
-- model test_bad_name + added should_not clauses

test_positive_clone
-- model and controller have test_copy

test_positive_create_composite
-- model test_composite_views_with_composite_versions

test_positive_create_with_description
-- controller: test_create

test_positive_create_with_name
-- model: test_create_with_name
-- controller: test_create

test_positive_publish_with_long_name
-- not ok to port atm, skipped due to BZ in pr #6019

test_negative_update_label
-- added should_not clauses

test_negative_update_name
-- added should_not clauses

test_positive_update_attributes
-- controller: test_update + added asserts

test_positive_update_name
-- controller: test_update

test_positive_delete
-- controller: test_destroy

[ldjebran]

@pondrejk you can already add test_attributes on the tests in question to have a clear picture what test is being ported and covered by which tests, also if the tests already exists in controllers you can add assertions on returned controller fields values so we will be sure that, that fields are really returned as expected by robottelo tests.
What do you think?

[ldjebran]

@pondrejk test_negative_update_label is not adequately covered, this test should not be ported at all
this test is still affected by this bug https://bugzilla.redhat.com/show_bug.cgi?id=1147100
The test in robottelo must be like this
(there is an error in robottelo test , the new value must be a valid label value and not a utf8, and the update must fail also, this is an other scenario from other simple update)

        with self.assertRaises(HTTPError):
            entities.ContentView(
                id=self.content_view.id,
                label=gen_string('alpha')).update(['label'])

Also the description we have to a should allow_values to be fully covered

[ldjebran]

@pondrejk by the otherhand we can add a robottelo test that rely on the fact that the label value was not updated