-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you add shortcuts and possibility to use '*' to add a note to all the matching urls? #13
Comments
I'll see what I can do 😄 About the shortcuts... you mean to open the popup to the specific tab or when you already opened the pop-up? In addition, what do you mean "Open All notes page"? As before, a generic shortcut? |
Thanks! I mean to open the popup and to the specific tab (covers also the other case: if it's already open, with the other shortcut will open the other tab - or it won't?)
Yes, basically a shortcut for the place where we will be able to perform a search |
@nik-gr shortcuts added in 2.3 😄 |
Thank you! There is one thing, as I understand when there is a note only for Domain or only for Page it will open that tab regardless the shortcut pressed. And some thoughts you may want to consider |
@nik-gr the "default" shortcut it's useful if you want to open the popup by the default choosing (and, in addition, you can close the popup with the same shortcut). I'll add the feature to change tab by shortcut also when opened and I'll fix bugs |
Published the update (2.3.1) which fixes many bugs (the icons weren't updated "in real time", shortcuts, etc.) |
still buggy: If there is a note for the domain it always opens the Domain tab regardless of shortcut (unlike before now it's happening even if there is a note also for the page) |
@nik-gr I cannot understand, sorry. Could you list me the steps to follow to get the error? Thanks |
If I have a note written for the Domain then whenever I am in a webpage from that domain with any of the 3 shortcuts the addon popup always opens the "Domain" tab showing the note I wrote. If I also have a Page note for the specific webpage I cannot open the "Page" tab to read it using the shortcut (instead it will display the Domain tab or hide it). And of course I cannot use the Page note shortcut to write a Page note for any webpage under that domain |
I'll check why the add-on presents that issue. Have you update to the latest version the add-on, right? |
Hi Saverio, with the new version it works as expected 👍 If it is an easy implementation it would be better if when the Domain/Page note is open and then use the shortcut for Page/Domain (=the shortcut of the other note type) to immediately change and open the other tab, as it is now it will hide the note and will display the other note after press the shortcut a 2nd time (but still it is functional so if it's not easy to implement the change it doesn't worth the effort) |
@nik-gr Now it should work in that way: if the addon (popup) is already opened you can switch tab via shortcuts. Doesn't it work to you? 🤔 |
Yes it does thank you! my comment was that to be able to switch you need to press the shortcut twice (1st time it hides the already opened note) but it's not really of an issue May I ask, are you considering to implement my other suggestion as well? (the one for notes using '*' in the url) |
@nik-gr about the shortcuts: you should already able to switch pressing just once the popup (if you get another behaviour maybe there is a bug... let me know, because to me it works great) About the other feedbacks, I'm still thinking, but actually I don't think it could be so useful; I mean, I'm basing on the KISS principle, and I think this is a feature that could interest just a few users... maybe in future I'll implement although. I hope you can enjoy anyway this add-on, sorry |
ok that's strange... for me if the popup is open the use of any shortcut will hide it |
Extension shortcuts to open (a) domain notes, (b) page notes pop ups and (c) for opening the All notes page
About
*
: For example with github.com/Sav22999/* to display the specific note when any of the pages under this github account are visitedPerhaps with an addition of an extra tab in the menu (next to "Domain" and "Page"). And by clicking there (or with shortcut) the popup will have the same place to write/read the related note but also one extra editable line maybe at the bottom with the url in an editable form so users can change it using '*' and add the note to all the matching urls.
The text was updated successfully, but these errors were encountered: