Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show active warfronts #281

Closed
Hemario opened this issue May 14, 2019 · 6 comments
Closed

Only show active warfronts #281

Hemario opened this issue May 14, 2019 · 6 comments
Labels
⏱ Awaiting Response More information is needed before any action can be taken. 🎨 Enhancement This issue is about a new feature.

Comments

@Hemario
Copy link

Hemario commented May 14, 2019

Add an option to enable/disable only showing active warfront for your faction.

@Hemario Hemario added the 🛠 Feature Request Feature request label May 14, 2019
@LiangYuxuan
Copy link
Collaborator

I think it is hard to tell if a warfront is active or not. it has different quests to complete and the indicator is more like a reminder.

@LiangYuxuan LiangYuxuan added the ⏱ Awaiting Response More information is needed before any action can be taken. label May 20, 2019
@TruthNZ
Copy link
Collaborator

TruthNZ commented May 20, 2019

This addon seems to be detecting it:
https://wow.curseforge.com/projects/warfront-rare-tracker

So it's possible somehow.

@LiangYuxuan
Copy link
Collaborator

This addon seems to be detecting it:
https://wow.curseforge.com/projects/warfront-rare-tracker

So it's possible somehow.

yes, actually SI uses the same APIs to check the status in Warfront Module. But I think he means to hide the line when corresponding warfront is contributing or other. I'm not quite sure about what "active" means.

@Hemario
Copy link
Author

Hemario commented May 20, 2019

By active I mean, the phase were the warfront is in its "launch attack" stage for the character's faction.
So yes, I'd like the hide the line if the warfront status is in any other status besides attack. It feels wrong to see "0/1" without the ability to change anything about it because the warfront scenario is not up.

@LiangYuxuan LiangYuxuan added 🎨 Enhancement This issue is about a new feature. and removed 🛠 Feature Request Feature request labels May 21, 2019
@LiangYuxuan
Copy link
Collaborator

By active I mean, the phase were the warfront is in its "launch attack" stage for the character's faction.
So yes, I'd like the hide the line if the warfront status is in any other status besides attack. It feels wrong to see "0/1" without the ability to change anything about it because the warfront scenario is not up.

Actually, it's blank at that stage, and "0/1" when scenario is ready.

@Hemario
Copy link
Author

Hemario commented May 21, 2019

I didn't realize that is the case

@LiangYuxuan LiangYuxuan added this to Soon™ in Timeline Jun 10, 2019
Timeline automation moved this from Soon™ to Done (Ready to release) Feb 2, 2021
@LiangYuxuan LiangYuxuan removed this from Done (Ready to release) in Timeline Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response More information is needed before any action can be taken. 🎨 Enhancement This issue is about a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants