Removed warnings about TODOs and FIXMEs from SwiftLint #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodericj - FYI since I saw you're working on the linter. |
|
I fixed the pod file ones in #63. I didn't address the ones you've addressed. |
|
Can we merge this PR into #63? (or whatever direction) |
|
@evilpenguin done over in #63. Shall we close this one? |
|
This was merged into #63. Closing. |
|
Gg @npvisual teamwork makes the dream work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in Remove TODO and FIXME warnings from SwiftLint I have added "todo" in the list of disabled rules.
Before the fix :
After the fix :
✋👇
Note : while I understand the desire to clean up messages from the build logs, it's however problematic, imo, to leave todos and fixmes in the code without either warnings or corresponding issues. So I will go through the code and see if there are existing cards corresponding to those todos and if not, I will file some.