Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification of StyleRenderer API #2

Open
robertvazan opened this issue Dec 27, 2021 · 0 comments
Open

Clarification of StyleRenderer API #2

robertvazan opened this issue Dec 27, 2021 · 0 comments

Comments

@robertvazan
Copy link

Methods onPushSubLanguage and onPushOriginalSubLanguage in StyleRenderer have the same javadoc. Furthermore, onPushOriginalSubLanguage seems to be only ever called with null name parameter. Looks like a remnant of previous changes that introduced generics.

Also whereas onPushSubLanguage gets formatted HTML, onPushOriginalSubLanguage seems to receive original unformatted source code (not tested, just looking at how it is called). And yet the default HtmlRenderer does not escape code parameter of onPushOriginalSubLanguage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertvazan