New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LeaderBoard API #5
Conversation
This reverts commit d0ef7c2. - I want to commit only the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sboursen, I am Hamza your reviewer for this PR 😸
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight
✔️ The repo looks professional
✔️ Git/GitHub flow best practices have been followed
✔️ There are no linter errors
✔️ You have a descriptive README
Required Changes ♻️
- in the second input from your form you were asked to enter a rating number, so it's a number, not a text, Please change
input type
tonumber
instead oftext
?
As you can see in the screenshot below I can add a rating as a text
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- [OPTIONAL] I think that you can add a scrollbar in your Leaderboard, to don't limit the table in just 10 rows what do you think
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @Hamzaoutdoors in your question so I can receive the notification ^_^
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @Hamzaoutdoors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sboursen,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description
In this milestone, I implemented an interface in order to communicate with API and created the refresh and the submit functionalities.
General requirements
Milestone requirements
Create a new game with the name of your choice by using the API.
Implement the "Refresh" button (receiving data from the API and parsing the JSON).
Implement the form "Submit" button (sending data to the API).
Use
async
andawait
JavaScript features to consume the API.Additional notes
Screenshote
NB:
I limit the number of displayed scores on the leaderboard to 10.
Thank you for taking the time to review this pull request.