This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
fix(orders): parse ShippingAddress as string
#367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks. Can you please also add some test cases for the data itself? Please see my previous PR where I modify the XML file and added the phone. You can just edit one of the entries too, and then replace all of the values with number-looking values. Then run Thanks. |
moltar
reviewed
May 4, 2021
| <ShippingAddress> | ||
| <Name>Jane Smith</Name> | ||
| <AddressLine1>22</AddressLine1> | ||
| <AddressLine2>kebab st</AddressLine2> |
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2021
## [1.9.49](v1.9.48...v1.9.49) (2021-05-04) ### Bug Fixes * **orders:** parse `ShippingAddress` as string ([#367](#367)) ([7909ef4](7909ef4))
|
🎉 This PR is included in version 1.9.49 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part2 or #365
All properties in
ShippingAddressare filled by customers and should be stringshttps://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_Datatypes.html#Address