Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource/scalingo_scm_repo_link): the auth_integration_uuid cannot be updated #161

Merged

Conversation

josephpage
Copy link
Contributor

As the "auth_integration_uuid" field cannot be updated according to the Scalingo API documentation, it is necessary to force the deletion/recreation of the resource to apply the change. That's what this PR does, which I thank you for looking at carefully.

Thank you very much again for your valuable work on this provider!

@EtienneM EtienneM requested a review from Soulou May 17, 2023 07:11
@Soulou
Copy link
Member

Soulou commented May 17, 2023

Thanks for the change

@Soulou Soulou enabled auto-merge May 17, 2023 07:43
@EtienneM EtienneM disabled auto-merge May 24, 2023 07:56
@EtienneM
Copy link
Member

Locally executed the tests and the linter:

  fix-scm-repo-link-auth-uuid-force-new  sc-golangci-lint --new-from-rev=$(git ls-remote origin master | cut -f1)
  fix-scm-repo-link-auth-uuid-force-new  grc go test -race -p=1 -count=1 ./...
?       github.com/Scalingo/terraform-provider-scalingo [no test files]
ok      github.com/Scalingo/terraform-provider-scalingo/scalingo        0.030s

@EtienneM EtienneM merged commit 78ca40c into Scalingo:master May 24, 2023
@josephpage josephpage deleted the fix-scm-repo-link-auth-uuid-force-new branch May 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants