Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource_scalingo_log_drain): make log_drain type mandatory #178

Merged
merged 3 commits into from Sep 6, 2023

Conversation

Frzk
Copy link
Contributor

@Frzk Frzk commented Sep 1, 2023

Fixes #176

It's required by our API, so it should be required by our TF provider too.
@Frzk Frzk changed the title fix: make log_drain type mandatory fix(resource_log_drain): make log_drain type mandatory Sep 1, 2023
@Frzk Frzk changed the title fix(resource_log_drain): make log_drain type mandatory fix(resource_scalingo_log_drain): make log_drain type mandatory Sep 1, 2023
@Frzk Frzk self-assigned this Sep 1, 2023
@Frzk Frzk marked this pull request as ready for review September 4, 2023 15:16
@Frzk Frzk requested a review from Soulou September 4, 2023 15:17
@Frzk Frzk merged commit 1779294 into master Sep 6, 2023
1 check passed
@Frzk Frzk deleted the fix/176/make_log_drain_type_mandatory branch September 6, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Resource LogDrain] The type property seems to be required
2 participants