Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashed with creation ViewNode with Plane object #190

Closed
ozh-dev opened this issue Dec 18, 2022 · 6 comments
Closed

Crashed with creation ViewNode with Plane object #190

ozh-dev opened this issue Dec 18, 2022 · 6 comments
Labels

Comments

@ozh-dev
Copy link
Contributor

ozh-dev commented Dec 18, 2022

When I need to create a Plane object, I also have to use a ViewNode. But the Plane object, when created, lost some parameters that will be needed in the future, and I have a crash.

And I have to use ugly workarounds to create the Plane properly.

ViewNode:
image

I think the main source of the problem is the Plane.kt arch, because the Plane class has no parameters from Geometry.

@ThomasGorisse Maybe you should reconsider creating a Plane.kt class?

@ThomasGorisse
Copy link
Contributor

Hi @ozh-dev.
Thanks for the report. I have to admit that I messed how will calls be at the end.
You're right on this Geometry fact
Would you mind creating a PR with a structure change proposal so we can discuss around it?

@ThomasGorisse
Copy link
Contributor

I will then publish a SceneView 1.0.0 (3D only) to maven central.

@ozh-dev
Copy link
Contributor Author

ozh-dev commented Dec 18, 2022

Hi @ozh-dev. Thanks for the report. I have to admit that I messed how will calls be at the end. You're right on this Geometry fact Would you mind creating a PR with a structure change proposal so we can discuss around it?

I have been doing a feature for my work with SceneView, And after it I'll think about fix for it, maybe I'll find more bugs

@Tnation87
Copy link
Contributor

Tnation87 commented Mar 17, 2023

I will then publish a SceneView 1.0.0 (3D only) to maven central.

Hi @ThomasGorisse , I fixed the crash here, the fix isn't ideal, but I think it should be considered a hot fix until the architecture of the parent is refactored

@github-actions
Copy link

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jun 16, 2023
@github-actions
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants