Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greedy pattern matching can cause ambiguity #836

Closed
jeffmacdonald opened this issue Sep 19, 2019 · 3 comments
Closed

Greedy pattern matching can cause ambiguity #836

jeffmacdonald opened this issue Sep 19, 2019 · 3 comments

Comments

@jeffmacdonald
Copy link
Contributor

Lets say you have 2 config files rds.yaml and rds-vpc.yaml

Then lets say you have 4 other config files, each using stack_outputs from each other so they're all linked and one of them is linked to rds-vpc.yaml, thus creating a dependency chain.

If you run this sceptre delete foo/boo/rds , sceptre will greedy match rds-vpc.yaml and will ask you if you'd like to delete EVERYTHING. Which isn't great.

If you run sceptre delete foo/boo/rds.yaml it will of course only delete the rds stack, which did not have any dependencies.

Suggestion: Require full file path for stack config files and do not rely upon greedy pattern matching.

@craighurley
Copy link
Contributor

This should be fixed by #731. That PR needs a little love to push it across the line.

@ngfgrant
Copy link
Contributor

Thanks for raising @jeffmacdonald closing as it is a duplicate of #546 and as @craighurley mentions will be resolved in #731

@jeffmacdonald
Copy link
Contributor Author

jeffmacdonald commented Sep 20, 2019

Sweet thanks! (it just bit me again in a new exciting way so this is great news :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants