Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFx: page resize with different aspect ratio #488

Open
musaffa opened this issue Feb 18, 2024 · 1 comment
Open

PDFx: page resize with different aspect ratio #488

musaffa opened this issue Feb 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@musaffa
Copy link
Contributor

musaffa commented Feb 18, 2024

Is your feature request related to a problem? Please describe.
Cannot resize a page with different aspect ratio.

PDFx caches the pages of PDF documents it renders. If we try to resize a page with a different aspect ratio, it just fetches the page from the page cache. Thus aspect ratio of the page doesn't change.

Describe the solution you'd like
When the aspect ratio of the container changes, PDFx should re-render the pages. Or there can be an option to opt into this behaviour.

Additional context

Here we start the pdf display without fullscreen. Then we go to the fullscreen mode, the pdf page doesn't take up the full screen. It shows the page it already rendered.
pdf-issue

If we start with the fullscreen, the pdf page takes up the whole screen. But we go out of the fullscreen, the it doesn't resize the page. It just shows the fullscreen version it rendered before.
pdf-issue-2

@musaffa musaffa added the enhancement New feature or request label Feb 18, 2024
@musaffa
Copy link
Contributor Author

musaffa commented Mar 6, 2024

@SergeShkurko Can you please give us any suggestion like where to look in the code to add this feature? We will try to submit a PR for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants