Report confidence interval for permutation feature importance #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, check() won't be able to find it. https://www.r-bloggers.com/2021/06/documentation-for-internal-functions/
Also mark find_permuted_perf_metric internal so doc will be created for developers to read.
Codecov ReportBase: 98.18% // Head: 98.19% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 98.18% 98.19%
=======================================
Files 13 13
Lines 1103 1109 +6
=======================================
+ Hits 1083 1089 +6
Misses 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
To fix this warning: Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0. i Please use `all_of(var)` (or `any_of(var)`) instead of `.data[[var]]`
Because `names()` is a base R function already, and it's not obvious that `names` referred to the feature or group of correlated features.
- `names` renamed to `feat` - `lower` and `upper` for bounds of 95% CI
courtneyarmour
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Change(s) made
namestofeatfor clarity and to avoid clashing with the basenames()function.Checklist
(
Strikethroughany points that are not applicable.)NEWS.mdif this includes any user-facing changes.