Skip to content
This repository has been archived by the owner on Jul 9, 2022. It is now read-only.

Naming of user object field name is not consistent across API #494

Open
tomquirk opened this issue Jun 20, 2017 · 2 comments
Open

Naming of user object field name is not consistent across API #494

tomquirk opened this issue Jun 20, 2017 · 2 comments

Comments

@tomquirk
Copy link
Contributor

tomquirk commented Jun 20, 2017

I've noticed that the naming of the name field in user objects is inconsistent across the API. It is also somewhat ambiguous as to what name refers to.

Example:

There are possibly other places where this is also the case. This clearly hinders development.

I propose that, in any case where a user object includes a full name (e.g. Tom Quirk), that field is named fullName. This would improve clarity and consistency across the API and eliminate ambiguity between name and firstName. I would be happy to submit a PR for this given a consensus 馃槃

@Schmavery
Copy link
Owner

Schmavery commented Jun 20, 2017

Sounds fine to me.

@bsansouci
Copy link
Collaborator

@tomquirk Let's do it! More consistency is better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants