Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound accompanying the effect? #101

Open
jose1711 opened this issue Feb 10, 2022 · 5 comments
Open

Sound accompanying the effect? #101

jose1711 opened this issue Feb 10, 2022 · 5 comments
Labels
contributions welcome Most likely, I will not work on this in the next couple of weeks feature request New feature or request

Comments

@jose1711
Copy link
Contributor

The Idea

Don't know if it's technically possible but would it somehow be possible to add a short and non-obtrusive sound effect esp. when the window is being closed? I think it could sit well with many of the existing effects (fire, broken glass, t-rex..).

The Alternatives

I've checked Gnome settings and could not find anything related to playing a sound when a window is being closed. Even Windows XP had a way to define custom sound for some events (quitting a program or minimize/maximize) which makes me wonder if Gnome desktop is really lacking this feature.

@jose1711 jose1711 added the feature request New feature or request label Feb 10, 2022
@Schneegans
Copy link
Owner

Thanks for the suggestion! I think it's a great suggestion as it would make the extension even more ridiculous 😆

However, finding free and non-obtrusive sound effects for going-up-in-flames, a t-rex attack, or glass shattering will be a challenge...

@Schneegans Schneegans added the contributions welcome Most likely, I will not work on this in the next couple of weeks label Feb 11, 2022
@Schneegans
Copy link
Owner

I just tested it and technically, it would be possible. However, finding fitting sound effects is really hard. Would you like help creating this feature by contributing some sound effects (with a permissive license)?

@Robby9705
Copy link

Robby9705 commented Apr 15, 2022

I Found This For The Tv Effect One: https://youtu.be/YMUtZy-nwAw
The Sound Starts From 0:03 And Ends At 0:04. It's Free Use Btw.

And This One For The Disintegration Effect: https://youtu.be/anBOuaxwDZI
I Think The One At 0:07 Is Perfect.

For The Glass Shattering Effect, I Think This One Sounds Right: https://youtu.be/vPqlaVOOsGg

For The Flames One: https://youtu.be/CLDnBBbWUZ0
I Can't Decide Which Sound Effect Is Better In This One :(

@Schneegans
Copy link
Owner

Schneegans commented Apr 17, 2022

Thanks for the links, @Robby9705! However, I do not like to include assets into the extension without a clear license. Even if the videos state "free to use" and "no copyright" it is not clear who created them, where the sound effects come from or under which conditions they can be redistributed.

I'll only include sound effects for which all of these things are clearly stated. For example, sound effects released under a Creative Commons License would be nice.

@SoftExpert
Copy link
Contributor

How about providing the possibility to configure which sound to use (specify a local path)? That way, everyone will be able to have the preferred sounds and you have no copyright issues ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Most likely, I will not work on this in the next couple of weeks feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants