Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No grouping side effect #132

Open
set-soft opened this issue Aug 12, 2020 · 0 comments
Open

No grouping side effect #132

set-soft opened this issue Aug 12, 2020 · 0 comments

Comments

@set-soft
Copy link
Contributor

I'm not sure about the following behavior:

KiBoM/kibom/component.py

Lines 120 to 121 in 06a1486

if len(self.prefs.groups) == 0:
return False

This disables the grouping mechanism, this is OK. But the side effect is that multi-part components will be repeated (as many times as sub-parts). I this the code should be:

if len(self.prefs.groups) == 0: 
    return self.getRef() == other.getRef()

So we don't get the same ref multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant