-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convergence tests fails #7
Comments
Yeah, convergence tests are ancient and they aren't really a part of the test suite (I just wrote them as a demonstration). I will take a look and either remove or update them. |
Could you add the convergence tests to the standard testing? That would be nice to ensure. If anyone else wants to modify the code, you'll want the convergence tests as part of Travis so you know nothing messed up the algorithm's fundamentals. |
I'm not sure if my convergence tests are up to the current standard. Shouldn't we test the convergence using an external package anyway? |
Probably, yes. We should get that up and running (I didn't do a DAE part of the convergence tests since I only wrapped Sundials for that, and I think we can trust Sundials). What are the problems used for testing DAEs? |
My tests just involved a simple exponential problem to catch the obvious errors:-).
That's a good question! I think ODETestSuite implemented some test cases, but I'm not an expert on that. |
You mean |
I tried to run the convergence test:
The text was updated successfully, but these errors were encountered: