Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unbound type parameters in NTuple #112

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ArnoStrouwen
Copy link
Member

This should fix the aqua unbound test, although I'm not a fan of this (particular?) solution.
I'm not sure if there is a quality issue in the first place.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25eece3) 95.65% compared to head (42a35fe) 95.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           9        9           
  Lines         207      207           
=======================================
  Hits          198      198           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@avik-pal avik-pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass this change is fine!

@ChrisRackauckas ChrisRackauckas merged commit b38c669 into SciML:main Dec 12, 2023
8 of 9 checks passed
@ArnoStrouwen ArnoStrouwen deleted the fix_unbound branch December 12, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants