working on spatially varying reaction rates, WIP #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
requested changes
Feb 11, 2022
isaacsas
requested changes
Feb 17, 2022
| @@ -52,13 +52,20 @@ end | |||
|
|
|||
| update rates of all reactions in rxs at site | |||
| """ | |||
| function update_rx_rates!(rx_rates, rxs, u, site) | |||
| function update_rx_rates!(rx_rates::RxRates{F,M}, rxs, u, site) where {F, M <: MassActionJump} | |||
There was a problem hiding this comment.
Why do we still need this version? Shouldn't we always just SpatialMassActionJumps internally for the spatial solvers now?
There was a problem hiding this comment.
MassActionJump has more utilities like parameter mapping and merging so I thought it's good to leave it as a sort of backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to be able to handle spatially varying reaction rates.