Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Uninitialized field opnorm in JacVecOperator #519

Open
danielwe opened this issue May 16, 2022 · 4 comments
Open

Uninitialized field opnorm in JacVecOperator #519

danielwe opened this issue May 16, 2022 · 4 comments

Comments

@danielwe
Copy link

opnorm is left uninitialized here:

new{T,typeof(f),Nothing,Nothing,Any,P,tType,typeof(opnorm)}(
f,
nothing,
nothing,
nothing,
nothing,
nothing,
autodiff,
ishermitian,
)

Another instance of JuliaLang/julia#24943

@danielwe
Copy link
Author

Same issue in vecjac_operators.jl:

new{T,typeof(f),Nothing,Nothing,Any,P,tType,typeof(opnorm)}(
f,
nothing,
nothing,
nothing,
nothing,
nothing,
autodiff,
ishermitian,
)

@ChrisRackauckas
Copy link
Member

These should probably just be deprecated and deleted in favor of the ones that are more updated in SparseDiffTools.

@xtalax
Copy link
Member

xtalax commented May 20, 2022

Are we sure that they are completely obselete? I'd prefer to leave the operators up for now until we have stencil interfaces in MOL for the high point count problems and warn of future deprecation, with links to successor packages.
Do MethodOfLines and SparseDiffTools cover all use cases?

@ChrisRackauckas
Copy link
Member

Yes, these ones are not robust to alternative tags like SparseDiffTools is, so pretty much any use case should use that. There's a few things in here that aren't in there to match the AbstractSciMLOperator interface, but what we probably need to do is just make that interface package a lean package and then let SparseDiffTools extend that, add the one function, and then there's no reason for the operators here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants