Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bruss for a new release of DiffEqOperators.jl #49

Open
YingboMa opened this issue Jul 16, 2019 · 5 comments · Fixed by #50
Open

Update Bruss for a new release of DiffEqOperators.jl #49

YingboMa opened this issue Jul 16, 2019 · 5 comments · Fixed by #50

Comments

@YingboMa
Copy link
Member

The API of DerivativeOperator has been changed.

https://github.com/JuliaDiffEq/DiffEqProblemLibrary.jl/blob/master/src/ode/brusselator_prob.jl#L100-L107

@kanav99
Copy link
Contributor

kanav99 commented Aug 8, 2019

Should we make a constructor of DerivativeOperator instead that acts as compatibility for such cases? We don't even have this stuff documented and this kind of change is scary.

@ChrisRackauckas
Copy link
Member

should it even use the DerivativeOperator?

@kanav99
Copy link
Contributor

kanav99 commented Aug 10, 2019

I just replaced

DerivativeOperator{Float64}(2,2,1/(N_brusselator_1d-1),
                                      N_brusselator_1d,
                                      :Dirichlet,:Dirichlet;
                                      BC=(1.,1.))

with

CenteredDifference{Float64}(2,2,1/(N_brusselator_1d-1),N_brusselator_1d)

and it worked for OrdinaryDiffEq tests. Is it right?

@ChrisRackauckas
Copy link
Member

yes that's good. PR.

@ChrisRackauckas
Copy link
Member

Still not completely fixed since I forgot it needs BCs as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants