-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bruss for a new release of DiffEqOperators.jl #49
Comments
Should we make a constructor of DerivativeOperator instead that acts as compatibility for such cases? We don't even have this stuff documented and this kind of change is scary. |
should it even use the DerivativeOperator? |
I just replaced DerivativeOperator{Float64}(2,2,1/(N_brusselator_1d-1),
N_brusselator_1d,
:Dirichlet,:Dirichlet;
BC=(1.,1.)) with CenteredDifference{Float64}(2,2,1/(N_brusselator_1d-1),N_brusselator_1d) and it worked for OrdinaryDiffEq tests. Is it right? |
yes that's good. PR. |
Merged
Still not completely fixed since I forgot it needs BCs as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The API of
DerivativeOperator
has been changed.https://github.com/JuliaDiffEq/DiffEqProblemLibrary.jl/blob/master/src/ode/brusselator_prob.jl#L100-L107
The text was updated successfully, but these errors were encountered: