Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Benchmarks #71

Open
dynamic-queries opened this issue Jun 23, 2022 · 13 comments
Open

More Benchmarks #71

dynamic-queries opened this issue Jun 23, 2022 · 13 comments

Comments

@dynamic-queries
Copy link

dynamic-queries commented Jun 23, 2022

It would be nice to have more benchmarks as they discuss here

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 24, 2022

It seems worthy to put those datasets to JuliaML/MLDatasets.jl.

@ChrisRackauckas
Copy link
Member

I think we shouldn't do them as datasets. We should setup the classical integrators with DifferentialEquations.jl, optimize them, and over at SciMLBenchmarks run the classical ones vs the neural operators and do a direct timing comparison. The current timing comparisons are absolutely dreadful because they have a handrolled MATLAB or Python PDE solver which is 😅 so I'd like to see real timings.

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 24, 2022

Oh! OK, we already have a mature benchmark system in SciML. I think we should do it for the Burger's equation as well.

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 24, 2022

While training a neural network still need prepared dataset, where should we get dataset from? To generate dataset directly from DifferentialEquations.jl in real time just before training? Or can we have a place to get generated dataset?

@ChrisRackauckas
Copy link
Member

For Burger's we have:

https://benchmarks.sciml.ai/html/MOLPDE/burgers_fdm_wpd.html
https://benchmarks.sciml.ai/html/MOLPDE/burgers_spectral_wpd.html

While training a neural network still need prepared dataset, where should we get dataset from? To generate dataset directly from DifferentialEquations.jl in real time just before training? Or can we have a place to get generated dataset?

I think for benchmarks it would be nice to see for example the PDE solve, and then the neural operator train, and then the speed difference, and then the accuracy at predicting new outputs.

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 24, 2022

Nice! Its the way to go.

@ChrisRackauckas
Copy link
Member

And Burger's is probably too simple of a test equation IMO. It's fine to show for handling of upwinding and the viscosity solution, but its dynamics are rather simple other than that.

https://diffeq.sciml.ai/stable/tutorials/advanced_ode_example/

Busselator might be a really nice example of a PDE to stress it.

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 24, 2022

I'm not that familiar with physical models, but it's great to have other examples other than Burger's.

@dynamic-queries
Copy link
Author

And Burger's is probably too simple of a test equation IMO. It's fine to show for handling of upwinding and the viscosity solution, but its dynamics are rather simple other than that.

https://diffeq.sciml.ai/stable/tutorials/advanced_ode_example/

Busselator might be a really nice example of a PDE to stress it.

I agree. In that vein, it would be interesting to add examples for the family of wave equations as well.

@YichengDWu
Copy link
Member

Also this paper might be a good reference
https://openreview.net/forum?id=dh_MkX0QfrK

@ChrisRackauckas
Copy link
Member

That's fine as a subset, but it's missing important classes of difficult to solve PDEs like Bruss.

@YichengDWu
Copy link
Member

What is the full name of Bruss?

@ChrisRackauckas
Copy link
Member

Brusselator Reaction-Diffusion PDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants