Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExponentialUtilities.exponential! instead of exp and add method as an option in solvers that currently use exp and expv #2009

Closed
howsiyu opened this issue Aug 4, 2023 · 1 comment · Fixed by #2018

Comments

@howsiyu
Copy link

howsiyu commented Aug 4, 2023

As per title. My main motive for this is that exp doesn't support AD (JuliaDiff/ForwardDiff.jl#174). This shouldn't affect existing code if we set the default method to be ExpMethodNative.

@ChrisRackauckas
Copy link
Member

We should just change it to ExpMethodGeneric which should be faster. All of the methods solve to floating point accuracy so there shouldn't be a noticable difference to the user, though it should open up autodiff support and improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants