Add Muller's method #139
Open
Add Muller's method #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikQQY
reviewed
Apr 11, 2024
avik-pal
reviewed
Apr 11, 2024
|
Does this method only work for scalars? |
|
Yes. It only works for univariate, scalar functions. |
avik-pal
reviewed
May 27, 2024
|
|
||
| function SciMLBase.solve(prob::NonlinearProblem, alg::SimpleMuller, args...; | ||
| abstol = nothing, maxiters = 1000, kwargs...) | ||
| @assert !isinplace(prob) "`SimpleMuller` only supports OOP problems." |
There was a problem hiding this comment.
Let's add some checks here for x is a 3 tuple and the elements are scalars
avik-pal
reviewed
May 27, 2024
src/nlsolve/muller.jl
Outdated
| """ | ||
| SimpleMuller() | ||
|
|
||
| Muller's method. |
There was a problem hiding this comment.
Make the documentation a bit more detailed. References, restrictions like only scalars and such
fgittins
commented
May 27, 2024
|
@ChrisRackauckas how should we go about this? This is a significant deviation from how the other problems need to be framed |
|
Treating it as an IntervalNonlinearProblem solver and then getting the third guess as the midpoint would be fine. |
|
That sounds like a good way to proceed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This implements the method discussed in SciML/NonlinearSolve.jl#403.