CompatHelper: bump compat for ADTypes to 1, (keep existing compat) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
===========================================
- Coverage 90.58% 57.99% -32.60%
===========================================
Files 23 23
Lines 1296 1295 -1
===========================================
- Hits 1174 751 -423
- Misses 122 544 +422 ☔ View full report in Codecov by Sentry. |
10 tasks
Vaibhavdixit02
approved these changes
Apr 27, 2024
|
@avik-pal a lot of CI is blocked https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/8850981778/job/24306501631?pr=2172 SciML/Optimization.jl#738 can you merge and release this? |
|
Is this not breaking for NonlinearSolve? I thought SciML/NonlinearSolve.jl#415 needs to be handled first |
|
No I think it just needs SciML/NonlinearSolve.jl#412 for now |
avik-pal
deleted the
compathelper/new_version/2024-04-19-22-04-48-101-01745084332
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
ADTypespackage from0.2.6to0.2.6, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.