Improve Code Standards #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avik-pal
commented
May 25, 2024
avik-pal
commented
- Explicit Imports
- Standardize formatting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 90.58% 90.60% +0.02%
==========================================
Files 23 23
Lines 1296 1299 +3
==========================================
+ Hits 1174 1177 +3
Misses 122 122 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
avik-pal
force-pushed
the
ap/explicit_imports
branch
2 times, most recently
from
3d29055
to
c6dc7b7
Compare
ChrisRackauckas
approved these changes
May 25, 2024
.JuliaFormatter.toml
Outdated
Comment on lines
0
to
5
| style = "sciml" | ||
| format_markdown = true | ||
| annotate_untyped_fields_with_any = false | ||
| format_docstrings = true No newline at end of file | ||
| format_docstrings = true | ||
| join_lines_based_on_source = false |
There was a problem hiding this comment.
@thazhemadam are we able to standardize this in the .github?
There was a problem hiding this comment.
annotate_untyped_fields_with_any = false is a better case only if ConcreteStructs are being used
There was a problem hiding this comment.
Though join_lines_based_on_source = false makes the formatting more standard across different authors
avik-pal
force-pushed
the
ap/explicit_imports
branch
from
c6dc7b7
to
9984298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.