Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #250

Open
ChrisRackauckas opened this issue Apr 9, 2020 · 4 comments
Open

Refactoring #250

ChrisRackauckas opened this issue Apr 9, 2020 · 4 comments

Comments

@ChrisRackauckas
Copy link
Member

Some of our code could use a pretty major refector. For example, we have a bunch of branches for all of the different linear operator choices, and this could be made much simpler.

https://github.com/SciML/Sundials.jl/blob/master/src/common_interface/solve.jl#L164-L231

It doesn't really much knowledge of the library itself, and would be a good way to learn.

@ViralBShah
Copy link
Contributor

Is there a good first issue sort of label in the SciML ecosystem?

@ChrisRackauckas
Copy link
Member Author

There was, I wonder if Github removed that?

@jd-lara
Copy link
Contributor

jd-lara commented Apr 9, 2020

I can take a swing at this. I will be able to spend time over the weekend. I also want to enable passing solver parameters for the linear solvers. I am thinking about interfacing them in a way consistent with DiffEq

@jd-lara
Copy link
Contributor

jd-lara commented Apr 9, 2020

is this related to #242 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants