We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(migrated from FedeOmoto#4)
proc set*(z, x: Int): Int = ## Sets `z` to `x` and returns `z`. result = z mpz_set(result[], x[])
it's misleading and un-necessary to return z given that z gets modified; nim code doesn't usually do that, and for good reasons.
z
inc+dec should have a 1 argument overload (eg would allow generic algorithms where inc/dec work with 1 arg)
inc
dec
module naming: Rat and Int are not great names, see also this thread https://forum.nim-lang.org/t/1296
Rat
Int
the fork should host its own version of the docs instead of pointing to the source repo https://github.com/FedeOmoto/bignum
The text was updated successfully, but these errors were encountered:
No branches or pull requests
(migrated from FedeOmoto#4)
eg: in
it's misleading and un-necessary to return
zgiven thatzgets modified; nim code doesn't usually do that, and for good reasons.inc+decshould have a 1 argument overload (eg would allow generic algorithms where inc/dec work with 1 arg)module naming:
RatandIntare not great names, see also this thread https://forum.nim-lang.org/t/1296the fork should host its own version of the docs instead of pointing to the source repo https://github.com/FedeOmoto/bignum
The text was updated successfully, but these errors were encountered: