Add more projection-specific tests #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to handle common changes if necessary, based on proj version or other factors.
This produces nicer error output with pytest as it can show the diff in a more fine-grained manner.
dopplershift
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In working on #1124, I was confused that other projections were not failing due to proj4 changes. It turns out that this is because some projections simply don't have tests, so never exercised the path through proj4 I thought would fail.
Implications
I added tests for everything from the Snyder 1987 manual (with #1138). There are also some new general smoke tests that other newer projections have. I also re-factored some of the proj4-string checking to use a common function comparing with
sets (these provide more informative diffs when there's something wrong.)