Potentially unused code in iris.coord

[bouweandela]

📰 Custom Issue

It looks like this class is not to be used anywhere and it not part of the public interface. Maybe it could be removed?

iris/lib/iris/coords.py

Lines 3156 to 3176 in ae2b59b

	# See ExplicitCoord._group() for the description/context.
	class _GroupIterator(Iterator):
	def __init__(self, points):
	self._points = points
	self._start = 0
	def __next__(self):
	num_points = len(self._points)
	if self._start >= num_points:
	raise StopIteration
	stop = self._start + 1
	m = self._points[self._start]
	while stop < num_points and self._points[stop] == m:
	stop += 1
	group = _GroupbyItem(m, slice(self._start, stop))
	self._start = stop
	return group
	next = __next__

[pp-mo]

@bouweandela actually, I think it is used,
here :

https://github.com/SciTools/iris/blob/main/lib/iris/analysis/__init__.py#L2344-L2346

Did you just miss that, or do you think there is an opportunity to simplify this ?

[bouweandela]

Did you just miss that

Yes! I must have been sleeping 😴

do you think there is an opportunity to simplify this ?

Yes, this looks like itertools.groupby. Is that what you had in mind?

[bjlittle]

@bouweandela Is this something that you wanted to take on? 🤔

[bouweandela]

Yes, I can have a look.

[bouweandela]

I think this was done in #5015.