Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Shift(s): bbb53585 #5280

Closed
github-actions bot opened this issue Apr 26, 2023 · 4 comments
Closed

Performance Shift(s): bbb53585 #5280

github-actions bot opened this issue Apr 26, 2023 · 4 comments
Assignees
Labels
Bot A bot generated issue/pull-request Type: Performance

Comments

@github-actions
Copy link
Contributor

Benchmark comparison has identified performance shifts at

Please review the report below and take corrective/congratulatory action as appropriate 🙂

Performance shift report
· Benchmark list file .asv/results/benchmarks.json missing!
  Use `asv run --bench just-discover` to regenerate benchmarks.json

Generated by GHA run 4814133164

@github-actions github-actions bot added Bot A bot generated issue/pull-request Type: Performance labels Apr 26, 2023
@lbdreyer
Copy link
Member

It looks like the benchmarks are failing when it tries to create an environment https://github.com/SciTools/iris/actions/runs/4814133164/jobs/8571480058#step:8:99

I see it mentions that the env.yml is not valid (https://github.com/SciTools/iris/actions/runs/4814133164/jobs/8571480058#step:8:72) which looks like a new error, as it doesn't appear in previous runs of the benchmarks

@trexfeathers
Copy link
Contributor

trexfeathers commented Apr 27, 2023

@trexfeathers
Copy link
Contributor

  • The fix is therefore: b558d0a
    Coming soon to a PR near you 🥵

#5286

@trexfeathers
Copy link
Contributor

Closed by #5286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot A bot generated issue/pull-request Type: Performance
Projects
None yet
Development

No branches or pull requests

2 participants