Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matplotlib deprecates munits.ConversionInterface.is_numlike #97

Closed
mathause opened this issue Nov 1, 2021 · 0 comments · Fixed by #106
Closed

matplotlib deprecates munits.ConversionInterface.is_numlike #97

mathause opened this issue Nov 1, 2021 · 0 comments · Fixed by #106
Labels
New: Issue Highlight a new community raised "generic" issue Type: Bug
Milestone
v1.4.1

Comments

@mathause
Copy link

mathause commented Nov 1, 2021 •
edited

Just FYI, matplotlib version 3.5 deprecates munits.ConversionInterface.is_numlike. Which you use here:

nc-time-axis/nc_time_axis/__init__.py

Line 433 in 5f2c4dc

if munits.ConversionInterface.is_numlike(value):

See matplotlib/matplotlib#20334 (lib/matplotlib/units.py - L137)

edit: seen in the xarray upstream test warnings.
@mathause mathause added New: Issue Highlight a new community raised "generic" issue Type: Bug labels Nov 1, 2021
This was referenced Apr 2, 2022
Merged
Closed
@spencerkclark spencerkclark added this to the v1.4.1 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New: Issue Highlight a new community raised "generic" issue Type: Bug
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging a pull request may close this issue.

Address deprecation of matplotlib's is_numlike method spencerkclark/nc-time-axis
2 participants
@spencerkclark @mathause