Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stratify option to use float32 #38

Open
abooton opened this issue Nov 7, 2019 · 4 comments
Open

Stratify option to use float32 #38

abooton opened this issue Nov 7, 2019 · 4 comments

Comments

@abooton
Copy link

abooton commented Nov 7, 2019

Model precision means that model data often only needs to be of type float32 or int32 data.
However, vertical stratify is currently converting data to float64 for its calculations. This is unnecessary for some usecases and too slow for some operational use cases.

AC:

  • Update stratify to accept and maintain data as float32.

See benfitzpatrick for more details.

@bjlittle
Copy link
Member

bjlittle commented Nov 7, 2019

@abooton Thanks 👍

@benfitzpatrick
Copy link

I tried converting to cython: floating (master...benfitzpatrick:float_32_preservation) but it didn't/doesn't work with the inheritance structure (fused type support + inheritance problem).

@pp-mo
Copy link
Member

pp-mo commented Mar 29, 2023

@SciTools/peloton reviewing this : leaving it open, but it won't happen for quite a while.
@benfitzpatrick is this still of interest ?

@benfitzpatrick
Copy link

Still of interest, I reckon, but @s-boardman and @PaulAbernethy now better points of contact!

In general I think the Scientific Python community needs to make much more use of float32 wherever possible - faster, less memory, don't need the bits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants