Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gui reencryption need offline handling #1016

Merged
merged 4 commits into from Mar 6, 2020

Conversation

touilleMan
Copy link
Member

fix #970

@touilleMan touilleMan requested a review from Max-7 March 3, 2020 15:00
touilleMan added a commit that referenced this pull request Mar 3, 2020
touilleMan added a commit that referenced this pull request Mar 3, 2020
@touilleMan touilleMan force-pushed the fix-gui-reencryption-need-offline-handling branch from 87e73a3 to b28cedb Compare March 3, 2020 16:36
touilleMan added a commit that referenced this pull request Mar 6, 2020
@touilleMan touilleMan force-pushed the fix-gui-reencryption-need-offline-handling branch from b28cedb to 56f70e2 Compare March 6, 2020 14:46
@touilleMan touilleMan force-pushed the fix-gui-reencryption-need-offline-handling branch from 56f70e2 to a61f400 Compare March 6, 2020 14:59
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1016 into master will increase coverage by 12.52%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1016       +/-   ##
===========================================
+ Coverage   67.55%   80.07%   +12.52%     
===========================================
  Files         221      263       +42     
  Lines       17182    21661     +4479     
===========================================
+ Hits        11607    17345     +5738     
+ Misses       5575     4316     -1259     
Impacted Files Coverage Δ
parsec/monitoring.py 51.42% <0.00%> (-11.43%) ⬇️
parsec/core/gui/ui/changelog_widget.py 22.22% <0.00%> (ø)
parsec/core/gui/ui/main_window.py 100.00% <0.00%> (ø)
parsec/core/gui/ui/central_widget.py 100.00% <0.00%> (ø)
parsec/core/gui/ui/notification_center_widget.py 100.00% <0.00%> (ø)
parsec/core/gui/ui/question_dialog.py 100.00% <0.00%> (ø)
parsec/core/gui/ui/device_button.py 100.00% <0.00%> (ø)
parsec/core/gui/ui/workspace_sharing_dialog.py 3.37% <0.00%> (ø)
parsec/core/gui/ui/new_version_available.py 7.69% <0.00%> (ø)
parsec/core/gui/ui/password_change_dialog.py 100.00% <0.00%> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1a4d1...a61f400. Read the comment docs.

@c4ffein c4ffein merged commit e5ac903 into master Mar 6, 2020
@c4ffein c4ffein deleted the fix-gui-reencryption-need-offline-handling branch March 6, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteDevicesManagerBackendOfflineError: User **** is not in local cache and we are offline.
3 participants