Workspaces as windows drives #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vxgmichel
force-pushed
the
windows-workspace-drives
branch
2 times, most recently
from
6ac08e7
to
eb41170
Compare
Max-7
approved these changes
May 13, 2020
This was referenced May 14, 2020
vxgmichel
force-pushed
the
windows-workspace-drives
branch
2 times, most recently
from
a444b33
to
8d183ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
+ Coverage 79.69% 80.06% +0.36%
==========================================
Files 280 281 +1
Lines 23606 23726 +120
==========================================
+ Hits 18813 18996 +183
+ Misses 4793 4730 -63
Continue to review full report at Codecov.
|
vxgmichel
force-pushed
the
windows-workspace-drives
branch
from
84fbf32
to
7b5f726
Compare
touilleMan
requested changes
May 28, 2020
touilleMan
reviewed
May 28, 2020
This was referenced Jun 3, 2020
This was referenced Jun 4, 2020
Closed
vxgmichel
force-pushed
the
windows-workspace-drives
branch
from
902d24d
to
9c66f34
Compare
vxgmichel
force-pushed
the
windows-workspace-drives
branch
from
76ddcbe
to
0a81540
Compare
touilleMan
approved these changes
Jun 8, 2020
| self.reset_timer = QTimer() | ||
| self.reset_timer.setInterval(1000) | ||
| self.reset_timer.setInterval(self.RESET_TIMER_THRESHOLD) |
There was a problem hiding this comment.
Shouldn't we use signals (fs.entry.updated I guess) instead of polling ?
If needed, the change would be for another PR of course ;-)
There was a problem hiding this comment.
This timer is not used for polling, it is used for throttling the requests to reset the GUI.
| assert await bar_txt.exists() | ||
|
|
||
|
|
||
| @pytest.mark.trio | ||
| @pytest.mark.mountpoint | ||
| @pytest.mark.skipif(os.name == "nt", reason="Windows uses drive") |
There was a problem hiding this comment.
Is there a test "drive already used" for windows ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing: #1142
Fixing: #928, #1058, #1081, #1082, #925, #913, #914, #912, #1126
Todo: