Disable reject_irp_prior_to_transact0 option for WinFSP #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling reject_irp_prior_to_transact0 is a fix to correct an incompatibily with Avast when using a folder as mountpoint. However this fix also prevents from knowing with precision when the mountpoint is ready which lead to flaky errors in the CI. Since Parsec have switched to drive based mountpoint (given doing folder-based is basically a dumpster fire full of nonsenses like the Avast craziness we got in the first place...) this fix is no longer required.
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 80.21% 80.26% +0.05%
==========================================
Files 280 280
Lines 23769 23809 +40
==========================================
+ Hits 19066 19110 +44
+ Misses 4703 4699 -4
Continue to review full report at Codecov.
|
vxgmichel
requested changes
Jun 18, 2020
|
@vxgmichel this is also done for fuse so I'm not sure... but let's try this with e4ed5c4 ! ^^ EDIT: The wait is still required :'( https://dev.azure.com/Scille/parsec/_build/results?buildId=1135&view=logs&j=bfccef3f-45d4-504d-9a7f-a8a74922e6bf&t=1b8d0bba-f11a-562f-077c-1aaa5fdf35ee&l=584 |
touilleMan
force-pushed
the
disable-winfsp-reject_irp_prior_to_transact0
branch
from
e4ed5c4
to
5d7ec31
Compare
vxgmichel
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1207 the proper way (not like #1208
)