Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless --db-drop-deleted-data option from backend run command #1246

Merged
merged 2 commits into from Jul 11, 2020

Conversation

touilleMan
Copy link
Member

@touilleMan touilleMan commented Jul 2, 2020

This option has never done anything and it wasn't part of the documentation so I guess it's safe to remove it entirely for the moment ;-)

@touilleMan touilleMan requested a review from vxgmichel July 2, 2020 17:21
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #1246 into master will increase coverage by 5.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
+ Coverage   69.87%   75.17%   +5.29%     
==========================================
  Files         298      298              
  Lines       26293    26305      +12     
==========================================
+ Hits        18372    19774    +1402     
+ Misses       7921     6531    -1390     
Impacted Files Coverage Δ
parsec/backend/cli/run.py 70.62% <ø> (-0.19%) ⬇️
parsec/backend/config.py 93.44% <ø> (-0.11%) ⬇️
parsec/core/gui/_resources_rc.py 80.00% <0.00%> (-1.25%) ⬇️
parsec/core/fs/userfs/userfs.py 84.15% <0.00%> (+0.21%) ⬆️
parsec/core/gui/workspaces_widget.py 70.25% <0.00%> (+0.25%) ⬆️
parsec/core/gui/files_widget.py 76.47% <0.00%> (+0.53%) ⬆️
parsec/core/fs/workspacefs/entry_transactions.py 97.05% <0.00%> (+0.58%) ⬆️
parsec/core/types/backend_address.py 92.92% <0.00%> (+0.58%) ⬆️
parsec/backend/app.py 93.84% <0.00%> (+0.76%) ⬆️
parsec/core/gui/trio_thread.py 91.66% <0.00%> (+1.11%) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012fc97...6f69a4c. Read the comment docs.

touilleMan added a commit that referenced this pull request Jul 11, 2020
@touilleMan touilleMan force-pushed the remove-db_drop_deleted_data-config branch from 0c94773 to 6f69a4c Compare July 11, 2020 08:46
@touilleMan touilleMan merged commit c90ec33 into master Jul 11, 2020
@touilleMan touilleMan deleted the remove-db_drop_deleted_data-config branch July 11, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant