Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify BackendAddr.from_url to refuse url with no hostname part inste… #1402

Merged
merged 2 commits into from Aug 27, 2020

Conversation

touilleMan
Copy link
Member

…ad of defaulting to localhost

@touilleMan touilleMan requested a review from Max-7 August 27, 2020 08:40
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #1402 into master will decrease coverage by 19.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1402       +/-   ##
===========================================
- Coverage   87.04%   67.84%   -19.20%     
===========================================
  Files         247      247               
  Lines       23014    23016        +2     
===========================================
- Hits        20033    15616     -4417     
- Misses       2981     7400     +4419     
Impacted Files Coverage Δ
parsec/core/types/backend_address.py 91.76% <100.00%> (-2.53%) ⬇️
parsec/core/mountpoint/winfsp_operations.py 0.00% <0.00%> (-95.17%) ⬇️
parsec/core/mountpoint/winfsp_runner.py 0.00% <0.00%> (-90.91%) ⬇️
parsec/core/mountpoint/winify.py 17.24% <0.00%> (-79.32%) ⬇️
parsec/core/gui/claim_device_widget.py 19.47% <0.00%> (-68.81%) ⬇️
parsec/win32.py 0.00% <0.00%> (-68.43%) ⬇️
parsec/core/gui/claim_user_widget.py 19.38% <0.00%> (-67.93%) ⬇️
parsec/core/gui/central_widget.py 17.22% <0.00%> (-67.78%) ⬇️
parsec/core/gui/greet_user_widget.py 18.79% <0.00%> (-67.45%) ⬇️
parsec/core/gui/create_org_widget.py 21.07% <0.00%> (-64.71%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d87940...17c1b09. Read the comment docs.

@touilleMan touilleMan merged commit 4090434 into master Aug 27, 2020
@touilleMan touilleMan deleted the backend_addr_from_url-not-default-hostname branch August 27, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants