Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable core file logging in packaging #1638

Merged
merged 3 commits into from Feb 23, 2021

Conversation

touilleMan
Copy link
Member

@touilleMan touilleMan commented Feb 10, 2021

closes #1616

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1638 (8a0af2c) into master (2c6da86) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
- Coverage   87.69%   87.59%   -0.10%     
==========================================
  Files         243      243              
  Lines       23385    23385              
==========================================
- Hits        20507    20485      -22     
- Misses       2878     2900      +22     
Impacted Files Coverage Δ
parsec/monitoring.py 50.98% <0.00%> (-37.26%) ⬇️
parsec/core/gui/central_widget.py 88.21% <0.00%> (-2.85%) ⬇️
parsec/backend/postgresql/block.py 88.40% <0.00%> (-1.45%) ⬇️
parsec/core/gui/custom_widgets.py 65.91% <0.00%> (-1.35%) ⬇️
parsec/core/backend_connection/transport.py 88.07% <0.00%> (-0.92%) ⬇️
parsec/core/gui/greet_user_widget.py 86.26% <0.00%> (+0.19%) ⬆️
parsec/core/fs/workspacefs/workspacefs.py 97.65% <0.00%> (+0.29%) ⬆️
parsec/core/fs/userfs/userfs.py 85.96% <0.00%> (+0.43%) ⬆️
parsec/core/fs/workspacefs/versioning_helpers.py 98.71% <0.00%> (+0.85%) ⬆️
parsec/core/sync_monitor.py 92.43% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6da86...8a0af2c. Read the comment docs.

packaging/macOS/launch_script.py Outdated Show resolved Hide resolved
@touilleMan touilleMan force-pushed the disable-core-file-logging-in-packaging branch from b018dd0 to 8b38263 Compare February 10, 2021 11:08
touilleMan added a commit that referenced this pull request Feb 10, 2021
@touilleMan touilleMan force-pushed the disable-core-file-logging-in-packaging branch from f05d206 to 8a0af2c Compare February 23, 2021 10:58
@touilleMan touilleMan merged commit d716ae6 into master Feb 23, 2021
@touilleMan touilleMan deleted the disable-core-file-logging-in-packaging branch February 23, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit log size in client
2 participants