Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing dialog when logging out with an on-going reencryption #1663

Merged
merged 2 commits into from Mar 23, 2021

Conversation

vxgmichel
Copy link
Contributor

A Cancelled exception was showed in a dialog with the confusing message:

Reencryption failed for unknown reason

when a user logs out with an on-going reencryption.

@vxgmichel vxgmichel requested a review from Max-7 March 19, 2021 18:46
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1663 (d77b2a4) into master (1add871) will increase coverage by 21.22%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1663       +/-   ##
===========================================
+ Coverage   66.49%   87.71%   +21.22%     
===========================================
  Files         243      243               
  Lines       23407    23409        +2     
===========================================
+ Hits        15564    20533     +4969     
+ Misses       7843     2876     -4967     
Impacted Files Coverage Δ
parsec/core/gui/workspaces_widget.py 83.54% <50.00%> (+59.81%) ⬆️
parsec/backend/postgresql/block.py 88.40% <0.00%> (-1.45%) ⬇️
parsec/backend/invite.py 89.36% <0.00%> (+0.28%) ⬆️
parsec/backend/postgresql/invite.py 96.42% <0.00%> (+0.59%) ⬆️
parsec/core/fs/userfs/userfs.py 85.96% <0.00%> (+0.64%) ⬆️
parsec/backend/organization.py 98.62% <0.00%> (+0.68%) ⬆️
parsec/core/local_device.py 93.38% <0.00%> (+0.73%) ⬆️
parsec/core/fs/exceptions.py 98.47% <0.00%> (+0.76%) ⬆️
parsec/core/mountpoint/fuse_runner.py 96.72% <0.00%> (+0.81%) ⬆️
parsec/core/fs/workspacefs/versioning_helpers.py 98.71% <0.00%> (+0.85%) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1add871...d77b2a4. Read the comment docs.

@vxgmichel vxgmichel merged commit c766ff6 into master Mar 23, 2021
@vxgmichel vxgmichel deleted the fix-reencrytpion-cancelled-dialog branch March 23, 2021 09:56
bitlogik added a commit to bitlogik/guardata that referenced this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants