Bsl licensed backend #1785
Merged
Bsl licensed backend #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
added a commit
that referenced
this pull request
Jul 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
==========================================
+ Coverage 87.74% 87.96% +0.22%
==========================================
Files 245 245
Lines 23834 24470 +636
==========================================
+ Hits 20912 21525 +613
- Misses 2922 2945 +23
Continue to review full report at Codecov.
|
touilleMan
force-pushed
the
bsl-licensed-backend
branch
from
72edebb
to
baa83e4
Compare
touilleMan
force-pushed
the
bsl-licensed-backend
branch
from
6f06e3d
to
f91c5d3
Compare
vxgmichel
reviewed
Jul 22, 2021
| yield path | ||
| elif not path.exists(): | ||
| raise SystemExit(f"Error: Path `{path}` doesn't exist !") | ||
| THIS_YEAR = "2021" # Change me when new year comes ;-) |
There was a problem hiding this comment.
Why not use date.today() like below?
There was a problem hiding this comment.
Because this would cause a CI breakage every January 1rst which requires modifying each file to solve :'(
So I think it's better to manually control when the change should occur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of projects with similar license:
MariaDB's MaxScale
ZeroTierOne
CouchBase
CockroachDB
Sentry