Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading msgpack to new version 1.0.3 #1929

Closed
alexandrediasldev opened this issue Dec 3, 2021 · 0 comments · Fixed by #1945
Closed

Upgrading msgpack to new version 1.0.3 #1929

alexandrediasldev opened this issue Dec 3, 2021 · 0 comments · Fixed by #1945
Assignees
Projects

Comments

@alexandrediasldev
Copy link
Contributor

alexandrediasldev commented Dec 3, 2021

Updating msgpack to version 1.0.3 produces a lot of errors
See this from another repo that explains why pupil-labs/pupil#1830

"Default value of strict_map_key is changed to True to avoid hashdos. You need to pass strict_map_key=False if you have data which contain map keys which type is not bytes or str."

Should we ignore the issue to have retro compatibility and change strict_map_key to False, or modify our implementation ?

ValueError: int is not allowed for map key when strict_map_key=True

FAILED tests/backend/realm/test_reencryption_maintenance.py::test_access_during_reencryption - parsec.api.protocol.base.Mess...
FAILED tests/backend/realm/test_vlob_access.py::test_list_versions_ok - parsec.api.protocol.base.MessageSerializationError: ...
FAILED tests/backend/realm/test_vlob_access.py::test_list_versions_check_access_rights - parsec.api.protocol.base.MessageSer...
FAILED tests/backend/realm/test_vlob_poll_changes.py::test_realm_updated_by_vlob - parsec.api.protocol.base.MessageSerializa...
FAILED tests/backend/realm/test_vlob_poll_changes.py::test_vlob_poll_changes - parsec.api.protocol.base.MessageSerialization...
FAILED tests/core/test_sync_monitor.py::test_autosync_placeholder_user_manifest - trio.TooSlowError
FAILED tests/core/test_sync_monitor.py::test_autosync_placeholder_workspace_manifest - trio.TooSlowError
FAILED tests/core/test_sync_monitor.py::test_autosync_on_modification - AssertionError: [SpiedEvent(event=<CoreEvent.FS_ENTR...
FAILED tests/core/test_sync_monitor.py::test_autosync_on_remote_modifications - parsec.core.fs.exceptions.FSFileNotFoundErro...
FAILED tests/core/test_sync_monitor.py::test_reconnect_with_remote_changes - parsec.core.fs.exceptions.FSFileNotFoundError: ...
FAILED tests/core/test_sync_monitor.py::test_sync_confined_children_after_rename - assert not True
FAILED tests/core/test_sync_monitor.py::test_sync_monitor_while_changing_roles - trio.TooSlowError
FAILED tests/core/test_sync_monitor.py::test_sync_with_concurrent_reencryption - parsec.core.fs.exceptions.FSFileNotFoundErr...
FAILED tests/core/fs/workspacefs/test_file_history.py::test_file_history - parsec.core.fs.exceptions.FSRemoteOperationError:...
FAILED tests/core/fs/workspacefs_timestamped/test_sync.py::test_sync_timestamp_consistency - parsec.core.fs.exceptions.FSRem...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_file_no_remove_minimal_synced - par...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_file_remove_minimal_synced - parsec...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_non_existing_file_remove_minimal_synced[False]
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_non_existing_file_remove_minimal_synced[True]
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_directory[False] - parsec.core.fs.e...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_directory[True] - parsec.core.fs.ex...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_version_non_existing_directory - parsec.core.fs.excep...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_not_enough_download_permited - parsec.core.f...
FAILED tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_backend_timestamp_not_matching - IndexError:...
ERROR tests/core/test_logged_core.py::test_init_online_backend_late_reply - assert not [<LogRecord: parsec.api.transport, 40...
ERROR tests/core/test_messages_monitor.py::test_revoke_sharing_trigger_event - assert not [<LogRecord: parsec.api.transport,...
ERROR tests/core/test_messages_monitor.py::test_new_reencryption_trigger_event - assert not [<LogRecord: parsec.api.transpor...
ERROR tests/core/test_sync_monitor.py::test_autosync_placeholder_user_manifest - assert not [<LogRecord: parsec.api.transpor...
ERROR tests/core/test_sync_monitor.py::test_autosync_placeholder_workspace_manifest - assert not [<LogRecord: parsec.api.tra...
ERROR tests/core/test_sync_monitor.py::test_autosync_on_modification - assert not [<LogRecord: parsec.api.transport, 40, /ho...
ERROR tests/core/test_sync_monitor.py::test_autosync_on_remote_modifications - assert not [<LogRecord: parsec.api.transport,...
ERROR tests/core/test_sync_monitor.py::test_reconnect_with_remote_changes - assert not [<LogRecord: parsec.api.transport, 40...
ERROR tests/core/test_sync_monitor.py::test_sync_confined_children_after_rename - assert not [<LogRecord: parsec.api.transpo...
ERROR tests/core/test_sync_monitor.py::test_sync_monitor_while_changing_roles - assert not [<LogRecord: parsec.api.transport...
ERROR tests/core/test_sync_monitor.py::test_sync_with_concurrent_reencryption - assert not [<LogRecord: parsec.api.transport...
ERROR tests/core/fs/workspacefs/test_file_history.py::test_file_history - assert not [<LogRecord: parsec.api.transport, 40, ...
ERROR tests/core/fs/workspacefs_timestamped/test_sync.py::test_sync_timestamp_consistency - assert not [<LogRecord: parsec.a...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_file_no_remove_minimal_synced - asse...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_file_remove_minimal_synced - assert ...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_non_existing_file_remove_minimal_synced[False]
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_non_existing_file_remove_minimal_synced[True]
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_directory[False] - assert not [<LogR...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_existing_directory[True] - assert not [<LogRe...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_version_non_existing_directory - assert not [<LogRecor...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_not_enough_download_permited - assert not [<L...
ERROR tests/core/fs/workspacefs_timestamped/test_workspacefs.py::test_versions_backend_timestamp_not_matching - assert not [...
======================== 24 failed, 1257 passed, 318 skipped, 1 xfailed, 22 errors in 63.51s (0:01:03) ========================
@alexandrediasldev alexandrediasldev added this to New comers in Dev Board via automation Dec 3, 2021
@alexandrediasldev alexandrediasldev changed the title Upgrading msgpack to new version Upgrading msgpack to new version 1.0.3 Dec 7, 2021
@alexandrediasldev alexandrediasldev linked a pull request Dec 7, 2021 that will close this issue
@alexandrediasldev alexandrediasldev moved this from New comers to Doing in Dev Board Dec 7, 2021
@alexandrediasldev alexandrediasldev self-assigned this Dec 7, 2021
@alexandrediasldev alexandrediasldev moved this from Doing to Done in Dev Board Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Dev Board
To review
Development

Successfully merging a pull request may close this issue.

1 participant