Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github action actions-rs/toolchain when its update to using node-16 #3261

Closed
FirelightFlagboy opened this issue Oct 12, 2022 · 0 comments · Fixed by #3282
Closed

Update github action actions-rs/toolchain when its update to using node-16 #3261

FirelightFlagboy opened this issue Oct 12, 2022 · 0 comments · Fixed by #3282
Assignees
@FirelightFlagboy
Labels
I-CICD Impact: CI/CD, automated stuff on this repo I-Dependency Impact: related to an dependency I-Github-Actions Impact: Github actions related stuff

Comments

@FirelightFlagboy
Copy link
Contributor

Github started deprecation of node-12 that is EOL.
We have actions-rs/toolchain that use that version.
We need to wait for them to update the node that they're using.
Here are the item that track this change:

After one of those is resolve (and most importantly, they aren't using node-12), we can update our action setup-rust in .github/actions/setup-rust
@FirelightFlagboy FirelightFlagboy added I-CICD Impact: CI/CD, automated stuff on this repo I-Dependency Impact: related to an dependency I-Github-Actions Impact: Github actions related stuff labels Oct 12, 2022
@FirelightFlagboy FirelightFlagboy linked a pull request Oct 13, 2022 that will close this issue
Remplace actions-rs/toolchain by dtolnay/rust-toolchain #3282
Merged
@FirelightFlagboy FirelightFlagboy self-assigned this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FirelightFlagboy FirelightFlagboy

Labels
I-CICD Impact: CI/CD, automated stuff on this repo I-Dependency Impact: related to an dependency I-Github-Actions Impact: Github actions related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remplace actions-rs/toolchain by dtolnay/rust-toolchain Scille/parsec-cloud
1 participant
@FirelightFlagboy