Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Poc for multi-instances #684

Merged
merged 29 commits into from Oct 18, 2019
Merged

[GUI] Poc for multi-instances #684

merged 29 commits into from Oct 18, 2019

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Sep 20, 2019

Just a POC for GUI multi-instances handled using tabs.

@Max-7 Max-7 added enhancement Improve functionality, potentially changing behavior in progress labels Sep 20, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #684 into master will decrease coverage by 39.4%.
The diff coverage is 49.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #684       +/-   ##
===========================================
- Coverage   86.53%   47.12%   -39.41%     
===========================================
  Files         159      253       +94     
  Lines       11183    21112     +9929     
===========================================
+ Hits         9677     9950      +273     
- Misses       1506    11162     +9656
Impacted Files Coverage Δ
parsec/core/types/__init__.py 100% <ø> (ø) ⬆️
parsec/core/gui/global_settings_widget.py 0% <ø> (ø)
parsec/core/gui/instance_widget.py 0% <0%> (ø)
parsec/core/gui/desktop.py 0% <0%> (ø)
parsec/core/gui/main_window.py 0% <0%> (ø)
parsec/core/gui/validators.py 0% <0%> (ø)
parsec/core/gui/app.py 0% <0%> (ø)
parsec/core/gui/claim_device_widget.py 0% <0%> (ø)
parsec/core/gui/register_user_dialog.py 0% <0%> (ø)
parsec/core/gui/register_device_dialog.py 0% <0%> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2076a...5ba2114. Read the comment docs.

@touilleMan touilleMan mentioned this pull request Oct 15, 2019
@Max-7 Max-7 merged commit 4231ef3 into master Oct 18, 2019
@Max-7 Max-7 deleted the gui-multi-instances-tab branch November 26, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve functionality, potentially changing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants