Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions warning for inconsistent dir #782

Merged
merged 5 commits into from Nov 20, 2019

Conversation

c4ffein
Copy link
Contributor

@c4ffein c4ffein commented Nov 4, 2019

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #782 into master will increase coverage by 12.46%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #782       +/-   ##
===========================================
+ Coverage   47.59%   60.05%   +12.46%     
===========================================
  Files         259      217       -42     
  Lines       21536    16806     -4730     
===========================================
- Hits        10250    10093      -157     
+ Misses      11286     6713     -4573
Impacted Files Coverage Δ
parsec/core/gui/file_history_dialog.py 0% <ø> (ø) ⬆️
parsec/core/gui/file_table.py 0% <0%> (ø) ⬆️
parsec/core/gui/files_widget.py 0% <0%> (ø) ⬆️
parsec/core/gui/file_items.py 0% <0%> (ø) ⬆️
parsec/core/mountpoint/winfsp_runner.py 0% <0%> (-94.34%) ⬇️
parsec/win32.py 0% <0%> (-68.43%) ⬇️
parsec/core/mountpoint/winfsp_operations.py 0% <0%> (-36.54%) ⬇️
parsec/core/ipcinterface.py 78.26% <0%> (-9.43%) ⬇️
parsec/core/config.py 80.85% <0%> (-7.45%) ⬇️
parsec/core/mountpoint/manager.py 62.83% <0%> (-5.41%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b1f5c...f489fe2. Read the comment docs.

@c4ffein c4ffein force-pushed the exceptions-warning-for-inconsistent-dir branch from 46318bf to f574eca Compare November 19, 2019 01:23
@c4ffein c4ffein changed the title [WiP] Exceptions warning for inconsistent dir Exceptions warning for inconsistent dir Nov 19, 2019
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome thanks! (tested with shared inconsistent data over several devices)

@c4ffein c4ffein merged commit b87a79c into master Nov 20, 2019
@c4ffein c4ffein deleted the exceptions-warning-for-inconsistent-dir branch November 20, 2019 17:53
@touilleMan touilleMan restored the exceptions-warning-for-inconsistent-dir branch November 20, 2019 21:42
@FirelightFlagboy FirelightFlagboy deleted the exceptions-warning-for-inconsistent-dir branch May 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants