Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling of list&revoke user #834

Merged
merged 5 commits into from Dec 4, 2019

Conversation

touilleMan
Copy link
Member

No description provided.

touilleMan added a commit that referenced this pull request Nov 25, 2019
parsec/core/gui/users_widget.py Outdated Show resolved Hide resolved
touilleMan added a commit that referenced this pull request Dec 2, 2019
@touilleMan touilleMan force-pushed the gui-fix-user-list-revoke-on-error branch from 82b7604 to e53add8 Compare December 2, 2019 08:47
@touilleMan
Copy link
Member Author

touilleMan commented Dec 2, 2019

@Max-7 tu peux me revalider ça vite fait stp

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #834 into master will decrease coverage by 12.26%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #834       +/-   ##
===========================================
- Coverage    80.1%   67.83%   -12.27%     
===========================================
  Files         263      221       -42     
  Lines       21661    16885     -4776     
===========================================
- Hits        17351    11454     -5897     
- Misses       4310     5431     +1121
Impacted Files Coverage Δ
parsec/core/gui/users_widget.py 22.99% <7.69%> (-61.53%) ⬇️
parsec/core/mountpoint/winfsp_runner.py 0% <0%> (-94.34%) ⬇️
parsec/core/gui/register_device_dialog.py 15.97% <0%> (-73.62%) ⬇️
parsec/core/gui/register_user_dialog.py 16.1% <0%> (-71.82%) ⬇️
parsec/win32.py 0% <0%> (-68.43%) ⬇️
parsec/core/gui/password_change_dialog.py 30% <0%> (-67.5%) ⬇️
parsec/core/gui/login_widget.py 25.19% <0%> (-64.13%) ⬇️
parsec/core/gui/mount_widget.py 29.54% <0%> (-63.64%) ⬇️
parsec/core/gui/file_table.py 12.11% <0%> (-62.98%) ⬇️
parsec/core/gui/replace_dialog.py 37.5% <0%> (-62.5%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c34bf...211b737. Read the comment docs.

touilleMan added a commit that referenced this pull request Dec 2, 2019
@touilleMan touilleMan force-pushed the gui-fix-user-list-revoke-on-error branch from e53add8 to 128d9ba Compare December 2, 2019 11:52
@touilleMan touilleMan force-pushed the gui-fix-user-list-revoke-on-error branch from 128d9ba to c6bbc80 Compare December 2, 2019 14:39
@touilleMan touilleMan force-pushed the gui-fix-user-list-revoke-on-error branch from c6bbc80 to 211b737 Compare December 2, 2019 15:35
@touilleMan
Copy link
Member Author

CI error not related (see #811)

@touilleMan touilleMan merged commit a381271 into master Dec 4, 2019
touilleMan added a commit that referenced this pull request Dec 17, 2019
@FirelightFlagboy FirelightFlagboy deleted the gui-fix-user-list-revoke-on-error branch May 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants