Add 'don't ask me again' for bundled addons install prompts

[joelmayer87]

Problem description

Note: I talked with the Developer of the Plugin, Toby R, and apparently this seems to be a Construct 3 Error and not caused by the Plugin.

We also tested this on his Computer and had the same Result.

This problem happens mostly with the "Animated Text Plugin" (available on the Scirra Store here: https://www.scirra.com/store/construct2-behaviours/animated-text-3868)

After creating a Project and adding this Addon and bundle it with the Project or having the Addon installed in the Addon Manager (where it shows up):

When i reload or open the Project again in C3, it asks me to install the Addon each and everytime.

Attach a .c3p

ttt.zip

Steps to reproduce

Way one:

1. Install the Animated Text Addon in the Addon Manager
2. Open the attached "ttt.c3p" file
3. Popup Message shows up asking to install the Addon

Way two:

1. Create a new Project
2. Create a Text Object
3. Add the Animated Text Behaviour to it
4. Save the Project (with our without "Bundle Addons with Project" doesn't really matter, both cause the same Result)
5. Close and re-open the just saved project

Observed result

C3 always asks me to install the Addon on starting the Project.

Expected result

That the Addon (if already installed in the Addon Manager on the current Browser) stays installed and doesn't re-install each time.

Affected browsers

• Chrome: yes

System details

Platform information
Browser: Chrome
Browser version: 61.0.3163.100
Browser engine: Blink
Browser architecture: 64-bit
Context: browser
Operating system: Windows
Operating system version: 7
Operating system architecture: 64-bit
Device type: desktop
Device pixel ratio: 1
Logical CPU cores: 12
Approx. device memory: (unavailable)
User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
C3 release: r60
Language setting: en-US

Local storage
Storage quota (approx): 61 gb
Storage usage (approx): 19 mb (0%)
Persistant storage: No

Browser support notes
This list contains missing features that are not required, but could improve performance or user experience if supported.

This browser does not support pluralisation rules. Plural forms may not be correct.
WebGL information
Version string: WebGL 2.0 (OpenGL ES 3.0 Chromium)
Numeric version: 2
Supports NPOT textures: yes
Supports GPU profiling: yes
Vendor: Google Inc.
Renderer: ANGLE (NVIDIA GeForce GTX 580 Direct3D11 vs_5_0 ps_5_0)
Major performance caveat: no
Maximum texture size: 16384
Point size range: 1 to 1024
Extensions:

EXT_color_buffer_float
EXT_disjoint_timer_query_webgl2
EXT_texture_filter_anisotropic
OES_texture_float_linear
WEBGL_compressed_texture_s3tc
WEBGL_compressed_texture_s3tc_srgb
WEBGL_debug_renderer_info
WEBGL_debug_shaders
WEBGL_lose_context
Audio information
System sample rate: 44100 Hz
Output channels: 2
Output interpretation: speakers
Supported decode formats:

Ogg Opus (audio/ogg; codecs=opus)
WebM Opus (audio/webm; codecs=opus)
Ogg Vorbis (audio/ogg; codecs=vorbis)
WebM Vorbis (audio/webm; codecs=vorbis)
MPEG-4 AAC (audio/mp4; codecs=mp4a.40.5)
MP3 (audio/mpeg)
FLAC (audio/flac)
PCM WAV (audio/wav; codecs=1)
Supported encode formats:

WebM Opus (audio/webm; codecs=opus)
Video information
Supported decode formats:

WebM VP9 (video/webm; codecs=vp9)
WebM VP8 (video/webm; codecs=vp8)
Ogg Theora (video/ogg; codecs=theora)
H.264 (video/mp4; codecs=avc1.42E01E)
Supported encode formats:

WebM VP9 (video/webm; codecs=vp9)
WebM VP8 (video/webm; codecs=vp8)

View details

PASTE HERE

[mOOnpunk]

This has always happened to me. I've only ever used LiteTween though. I assumed it is intentional though as if you have "bundle addons" checked then it make sense because the bundled plugin version attached to the project might be a different version to one you have installed on your computer, so its likely there to preserve the project compatibilty as new versions of the plugin might have changed things.

[joelmayer87]

Weird thing is, it doesn't do that with rex's CSV Addon which i also have installed... No other 3rd Party Plugins in use though...

[AshleyScirra]

This is currently by design. When you install an addon normally, a prompt appears to warn about the security implications and get the user to confirm. When you bundle addons in to a project and open the project, it temporarily installs the addon for use with the project. This has the same security implications so we show the same confirmation prompt. If we removed the prompt for bundled addons, then anyone trying to exploit you with a malicious addon would simply bundle it with a project to circumvent the normal confirmation.

I suppose we could add a "don't ask me again" option to white-list specific versions of specific addons. I'll leave this issue open as a feature request for that.

[shortercode]

Given that a malicious plugin could use the same version and id as a trusted plugin we should probably store more information than the ID in the whitelist.

[joelmayer87]

Hello @AshleyScirra @shortercode

That explains it, thanks for clearing that up, good idea about the don't ask me again ;)

[AshleyScirra]

@shortercode - I was going to store a hash of the addon file in the whitelist.

[shortercode]

@AshleyScirra yeah that was what I was thinking

[TobyReeno]

IMO a central database for addons would solve this and many other issues, see here https://construct3.ideas.aha.io/ideas/C3-I-344

[AshleyScirra]

Implemented this for r66.